ppp
ppp copied to clipboard
ppp-project
If mppe is not enabled, requests for mppe with all options turned off are rejected but logically should be accepted.
There appear to be routers out there (Archer C9 for example) which support PPPoE and not mppe, but for some daft reason they send an mppe request with all options turned off, i.e. they request mppe with all options off, and pppd says - rejected, even though that's actually what it's already doing.
The connection works, but with debug on you get a continual stream of
rcvd [CCP ConfReq id=0x1 <mppe -H -M -S -L -D -C>]
sent [CCP ConfRej id=0x1 <mppe -H -M -S -L -D -C>]
messages every few seconds, which seems wasteful if nothing else. It's easy enough to fix this in the code by just accepting these mppe requests even if mppe is disabled, and I wondered if there was any interest in fixing this - I'd be happy to contribute a patch if so.
@paulusmack: Have you seen this ticket?
Linked to:
- https://github.com/ppp-project/ppp/issues/57
For starters, the peer is buggy, because rfc1661 says that, having received a configure-reject for an option, the peer MUST NOT include that option in a subsequent configure-request. However, that doesn't mean we shouldn't try to be accommodating.
I haven't actually checked what the RFC for MPPE (RFC3078) says about configure-requests with no options enabled, but I guess it's probably OK to configure-ack such a request if MPPE is disabled on our end. (If MPPE is enabled, the code already does a configure-nak on a request with no options enabled.) If you want to try that and submit a patch or pull request, I'm happy to take a look at it.
Dear all, it is possible to check this ticket?
It will be nice to have a solution before a new PPP version...
cc: @jkroonza, @enaess, @jjkeijser.
Linked to:
- https://github.com/ppp-project/ppp/issues/57
- https://github.com/ppp-project/ppp/issues/430
- https://github.com/ppp-project/ppp/issues/558
- https://github.com/ppp-project/ppp/issues/541