ppp icon indicating copy to clipboard operation
ppp copied to clipboard

Configuring with --enable-microsoft-extensions=no breaks the compile

Open paulusmack opened this issue 1 year ago • 5 comments

After configuring with --enable-microsoft-extensions=no, running make gives:

  CC       pppd-peap.o
peap.c: In function ‘peap_init’:
peap.c:522:12: error: ‘struct peap_state’ has no member named ‘chap’
  522 |         psm->chap = chap_find_digest(CHAP_MICROSOFT_V2);
      |            ^~
make[2]: *** [Makefile:1520: pppd-peap.o] Error 1

@enaess ?

paulusmack avatar Sep 30 '24 04:09 paulusmack

If you disable Microsoft extensions then you might as well disable peap in the configuration too. Mschap is the only working peap method at this point.

enaess avatar Oct 11 '24 15:10 enaess

So then we should make peap depend on ms-extensions at the configure stage...

paulusmack avatar Oct 14 '24 06:10 paulusmack

@paulusmack for the time being, I think that would be appropriate. There might be a time in the future someone would add e.g. PEAP-SHA1 or something similar, which should allow configuring PEAP with whatever it supports. But since MsChapv2 is the only supported PEAP mechanisms now, then yes ...

enaess avatar Oct 15 '24 17:10 enaess