ppp icon indicating copy to clipboard operation
ppp copied to clipboard

Missing configure script in 2.5.0 release

Open vostrelt opened this issue 1 year ago • 6 comments

Hello there,

previous releases had configure scripts shipped with them. I understand that starting from version 2.5.0, automake is used. However, wouldn't it be better to generate the configure scripts for the releases?

Thanks for your work, Tomáš

vostrelt avatar Feb 05 '24 11:02 vostrelt

@enaess how do we get a pre-built configure script included in the generated tarball?

paulusmack avatar Feb 13 '24 09:02 paulusmack

As a part of the release process one should run

./autogen.sh
# configure runs ...
make dist-gzip

This should create the tarball (ppp-2.5.1.tar.gz) that is to be released and includes the configure script. Now, if you use GitHub to tag / create a release, the entire source tree is zipped up as "release evidence". This is different than the .tar.gz generated by the automake scripts which is the release tarball (which does not include autogen.sh, but does include configure).

@paulusmack

enaess avatar Feb 13 '24 14:02 enaess

Since distributions want to generate the configure script at build time and random users are not really supposed to build ppp themselves then I think that it is totally fine if they also have to run autogen.sh.

rfc1036 avatar Mar 17 '24 11:03 rfc1036

@rfc1036 I think requiring a package to run 'autogen.sh' brings along a bunch of extra dependencies for the package to build.

You as a packager may see something different in practice, but I'd say most projects do not distribute the autogen.sh, it's used by developers to bootstrap the build.

This is why I suggested just follow the intended design and omit the autogen.sh and to use configure

enaess avatar Mar 17 '24 15:03 enaess