ppp
ppp copied to clipboard
ppp-project
CI: add scheduled Coverity scan
@chipitsine Even with another email address, will it be possible for people not having access to the email account to get access to the Coverity reports ?
@chipitsine Even with another email address, will it be possible for people not having access to the email account to get access to the Coverity reports ?
sure.
@RICCIARDI-Adrien , even now, scheduled scan is not available yet, I ran scan manually. if you have capasity/will to review findings, I can add you account
I'm not fond of a solution that is not fully open source, so maybe we can add continue-on-error: true (see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error) to the job, so the whole CI is not blocked if something goes wrong with this specific job (for instance, the free license changes).
It is scheduled CI, it does not block "on push" builds
On Mon, Oct 2, 2023, 20:16 Adrien RICCIARDI @.***> wrote:
I'm not fond of a solution that is not fully open source, so maybe we can add continue-on-error: true (see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error) to the job, so the whole CI is not blocked if something goes wrong with this specific job (for instance, the free license changes).
— Reply to this email directly, view it on GitHub https://github.com/ppp-project/ppp/pull/439#issuecomment-1743433443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQ5KUB6FZ3U22XFGFBG2JDX5LZFBAVCNFSM6AAAAAA3I55T3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTGQZTGNBUGM . You are receiving this because you were mentioned.Message ID: @.***>
So, what happens if Coverity decides that there is an error? Just an email to somewhere, or what?
coverity has nice web UI
it is already setup, I can add you to project (I need your email).
project members can browse issue in UI, also email is sent to them on new issues
project members can browse issue in UI, also email is sent to them on new issues
Please add me, [email protected].
How are the coverity scans done today? Do you do some manual step to trigger a scan, or something?
What are our options in the situations where coverity says something is an error but in fact it's correct? We have seen such situations in the past.
project members can browse issue in UI, also email is sent to them on new issues
Please add me, [email protected].
How are the coverity scans done today? Do you do some manual step to trigger a scan, or something?
What are our options in the situations where coverity says something is an error but in fact it's correct? We have seen such situations in the past.
there are few ways.
- you can mark finding as "intentional" or "false positive"
-
alternatively, false positive may be marked in code comments https://community.synopsys.com/s/article/Suppressing-False-Positive-Intentional-defects
-
or via model https://community.synopsys.com/s/article/How-to-write-a-function-model-to-eliminate-a-false-positive-in-a-C-applilcation
project members can browse issue in UI, also email is sent to them on new issues
Please add me, [email protected].
How are the coverity scans done today? Do you do some manual step to trigger a scan, or something?
I've created CI task in my fork: https://github.com/chipitsine/ppp/tree/coverity I merge master branch from time to time
project members can browse issue in UI, also email is sent to them on new issues
Please add me, [email protected].
I sent an invitation (maybe it reached spam folder)
The invitation did go to spam, but I found it.
Seems like coverity is complaining nearly every time we use warn() (or info(), fatal(), error(), etc.) because of the existence of implementations of those functions in pppd/plugins/pppoe/pppoe-discovery.c, which of course are not the implementations that get compiled into pppd. I guess it has no understanding of makefiles and just blindly assumes all source files are compiled into one big mess.
The invitation did go to spam, but I found it.
Seems like coverity is complaining nearly every time we use warn() (or info(), fatal(), error(), etc.) because of the existence of implementations of those functions in pppd/plugins/pppoe/pppoe-discovery.c, which of course are not the implementations that get compiled into pppd. I guess it has no understanding of makefiles and just blindly assumes all source files are compiled into one big mess.
it does not make any assumption. it just follows the build process
it does not make any assumption. it just follows the build process
So why does it think that the warn() called from various places in ipcp.c could ever be the warn() defined in pppoe-discovery.c? Those two files are never compiled into the same executable. The calls in ipcp.c are to the warn() defined in utils.c. But when you look at the coverity errors, it is clearly linking the call in ipcp.c to the function in pppoe-discovery.c.
there's non zero probabilty that "ppp" configures itself to use plugins from pppoe folder.
I ran steps from CI, in folder "pppd" I see:
~/ppp/pppd$ grep -i pppoe Makefile | grep -i include
DEFAULT_INCLUDES = -I. -I$(top_builddir)/pppd/plugins/pppoe
~/ppp/pppd$
there's non zero probabilty that "ppp" configures itself to use plugins from pppoe folder.
Sure... and?
The point is that coverity is putting together a use of a function (in this case, warn()) in pppd with a definition which is not part of pppd or the pppoe plugin. To say it a different way, the code in pppoe-discovery.c (which contains an implementation of warn()) never appears in the address space of a pppd process. It is not part of pppd and it is not part of the pppoe plugin. What it is, is part of a separate standalone program which happens to use some of the same source code as the pppoe plugin (but note that the shared code does not include pppoe-discovery.c).
The result of coverity not understanding what gets linked with what is that it complains about things that are perfectly fine, making it quite hard to see what things do actually need attention.
I have no problem with coverity combining the code for pppd with the code for the pppoe plugin. But not all the source code in the pppd/plugins/pppoe directory goes into the pppoe plugin.
I just saw a new batch of scan results via email. They all seem to be predicated on the assumption that read() can return absolutely any integer, whereas by definition the return value is bounded by the 3rd argument, or is -1 indicating error. (And if the kernel is sufficiently broken that it is returning large positive values from read() then we have much bigger problems at hand than a few integer overflows.) The only one that isn't completely bogus points out a place where we don't check for error when reading /dev/urandom, which we should fix.
I remain unimpressed by the signal-to-noise ratio of these coverity scan results.
Oh, and there were a couple of reports that would be valid if tdb->hash_size could ever be >= 2^31. But if you look at the code, it's only ever going to be 131.
coverity is trying to develop their software. not every time is successful. they deployed overflow checks in june 2024, those integer overflow checks now are just noise
I ran new scan to find out whether this commit https://github.com/ppp-project/ppp/commit/cb593953b52597e1d2b09c9056e1f4ab15462c7c is noticed by coverity
in fact, it was