ppp icon indicating copy to clipboard operation
ppp copied to clipboard

pppd: De-duplicate Linux rtnetlink code

Open pali opened this issue 2 years ago • 0 comments

Move common code for sending rtnetlink message into the new send_rtnetlink_msg() function.

pali avatar Aug 09 '22 22:08 pali

@jkroonza I added second commit into this PR which de-duplicate rtnetlink stats code. Could you please at it?

pali avatar Aug 14 '22 21:08 pali

In principle this looks good and I'm in agreement. I've only looked over the code, and I've not actually tested this right now, happy to assist with that if needed, but I don't have a test environment for this set up currently but can do so if needed.

I have tested second commit just by extracting whole rtnetlink code into separate file / executable and run it and checked that returned values are same as statistics reported by ip -s link output.

pali avatar Aug 16 '22 21:08 pali

In principle this looks good and I'm in agreement. I've only looked over the code, and I've not actually tested this right now, happy to assist with that if needed, but I don't have a test environment for this set up currently but can do so if needed.

I have tested second commit just by extracting whole rtnetlink code into separate file / executable and run it and checked that returned values are same as statistics reported by ip -s link output.

Good enough for me. Thank you for your work on this. I'm also quite happy with your other explanations, so from my side: lgtm.

jkroonza avatar Aug 17 '22 10:08 jkroonza