ppp icon indicating copy to clipboard operation
ppp copied to clipboard

Restore DCO check

Open paulusmack opened this issue 4 years ago • 5 comments

Somewhere in the process of setting things up to build and test the software, we lost the DCO check (the check that each commit has a Signed-off-by: line). We need to get that back.

paulusmack avatar Nov 20 '21 05:11 paulusmack

@RICCIARDI-Adrien, @enaess: If you can look it ^^

Neustradamus avatar Nov 20 '21 06:11 Neustradamus

Hi @paulusmack, DCO check might have been lost during the repository organization migration. You can install this GitHub app https://github.com/apps/dco to enable DCO checking.

RICCIARDI-Adrien avatar Nov 20 '21 14:11 RICCIARDI-Adrien

I think that the page has been changed:

  • https://github.com/probot/dco/blob/master/docs/required-statuses.md

Neustradamus avatar Nov 22 '21 03:11 Neustradamus

I did see the DCO check flagged two of my changes recently and had a red X marked in front of it in the workflows. Seems like this has been fixed now, no?

enaess avatar May 31 '22 15:05 enaess

As said by @enaess, DCO check is working (see the following picture taken from a pull request), so this issue may be closed. Capture d’écran_2022-08-19_10-05-43

RICCIARDI-Adrien avatar Aug 19 '22 08:08 RICCIARDI-Adrien