ppp
ppp copied to clipboard
ppp-project
new ppp release ?
The last ppp release was quite some time ago. Is a new one forthcoming ?
Yes, a new release is very much needed - ppp no longer compiles on Gentoo.
This has been fixed in commit https://github.com/paulusmack/ppp/commit/3c7b86229f7bd2600d74db14b1fe5b3896be3875 - "pppd: Use openssl for the DES instead of the libcrypt / glibc".
Please consider creating a new release ASAP.
Yes, a new release is very much needed - ppp no longer compiles on Gentoo.
Part of the problems of the ppp as the project is completely crappy and custom made set of makefiles and custom configure script. It would be good to move to even autoconf/automake/libtool. It would be good to know it that kind of ppp improvements would be welcome by maintainer or not.
+1 (since 2014)
Note: There are patches here: https://www.nikhef.nl/~janjust/ppp/
Please look this ticket: https://github.com/paulusmack/ppp/issues/131
EDIT : Merged, good job @jjkeijser!
@paulusmack, @joakim-tjernlund, @hansfn, @kloczek: What do you think for an official perfect build?
A release would be great but seems like github is not the place Paulus wants to discuss, see https://github.com/paulusmack/ppp/commit/347904e33a8a1993316e57445a1ba8243cd947ce
Right. I do prefer mailing lists (i.e. the [email protected] list).
However, since we're here, do you all think the tree in its current state is releaseable, or are there things that must be fixed before release?
Paul,
Please understand that asking to subscribe on mailing list to ask the question is kind of overkill.
Mailing lists are OK in case of long term commitment to join the project. For anything else github issue tickets are all what is needed. Many github projects already abandoned even mailing list and they are using issues tickets as topics to discuss. You can have look on https://github.com/att/ast/issues/ to see how it works. It is better because it allows automatically connect discussions with already submitted patches, tickets or content of the projects (if github module has entries in projects tab). Using that way everything is easy to track and additionally in one place.
So going back to the subject: do you have any plans to make new release soon? :)
@paulusmack: The list is a big mess...
Can you look for integrate patches here too? https://www.nikhef.nl/~janjust/ppp/
Please look this ticket: https://github.com/paulusmack/ppp/issues/131
EDIT : Merged, good job @jjkeijser!
@paulusmack: The list is a big mess...
What list? The mailing list, or are you referring to some list of patches, or some other list?
Can you look for integrate patches here too? https://www.nikhef.nl/~janjust/ppp/
That's rather large. I would need a signoff at least. I would also want James Carlson to review and ack it. Please post it to linux-ppp (with a Signed-off-by, and a From: line if you are not the author) so he sees it. Please also consider splitting it, if that would make a series of logical steps that are easier to review.
It would be good to move to even autoconf/automake/libtool.
Puke. My experience of autoconf/automake has been that their output is verbose, unreadable and undebuggable. For a small project like ppp that only supports Linux and Solaris there isn't a lot that needs to be configured, so I prefer something that's simple and direct and understandable.
So going back to the subject: do you have any plans to make new release soon? :)
Yes, I would like to make a new release soon. The question is whether I just release what's in the tree now, or if there are some patches that are really needed before release.
I propose to release the tree as it currently is (plus updates to README and pppd/patchlevel.h) as ppp-2.4.8 shortly.
Maybe add https://github.com/paulusmack/ppp/pull/53 too? Fixing the CFLAGS/LDFLAGS is something many distros need I think.
IMO priority for now should be first release all already committed changes than as often as possible release all pending things in smaller chunks.
I'm going to do another release soon with the CVE fix. I am not going to merge any of the EAP patches for this release, as they are all fairly large and all need more review. I have merged a few small and safe fixes and I could add some more as long as they are obviously correct.
If may I ask you to have look on all Fedora parches https://src.fedoraproject.org/rpms/ppp/tree/master
@kloczek
If may I ask you to have look on all Fedora parches https://src.fedoraproject.org/rpms/ppp/tree/master
There is also a lot of pending patches, at least, in Debian and OpenWrt:
Debian (individual patches in debian/patches/ ): git clone https://salsa.debian.org/debian/ppp.git debian
OpenWrt (individual patches in package/network/services/ppp/patches/ ): git clone https://git.openwrt.org/openwrt/openwrt.git openwrt
Fedora: git clone https://src.fedoraproject.org/rpms/ppp.git fedora
@kloczek
If may I ask you to have look on all Fedora parches https://src.fedoraproject.org/rpms/ppp/tree/master
There is also a lot of pending patches, at least, in Debian and OpenWrt:
Debian (individual patches in debian/patches/ ): git clone https://salsa.debian.org/debian/ppp.git debian
OpenWrt (individual patches in package/network/services/ppp/patches/ ): git clone https://git.openwrt.org/openwrt/openwrt.git openwrt
Fedora: git clone https://src.fedoraproject.org/rpms/ppp.git fedora
Thanks for the references, that is helpful.
While there are some patches in those repos that I can (and will) apply, most of the patches in those distro packages are generally not up to the standard that I want:
-
They usually don't have any authorship information or Signed-off-by line
-
They usually don't have any description at all explaining what is being fixed or why this is a good change to make
(The openwrt patches do seem to be better than most in these respects.)
@kloczek
If may I ask you to have look on all Fedora parches https://src.fedoraproject.org/rpms/ppp/tree/master
There is also a lot of pending patches, at least, in Debian and OpenWrt: Debian (individual patches in debian/patches/ ): git clone https://salsa.debian.org/debian/ppp.git debian OpenWrt (individual patches in package/network/services/ppp/patches/ ): git clone https://git.openwrt.org/openwrt/openwrt.git openwrt Fedora: git clone https://src.fedoraproject.org/rpms/ppp.git fedora
Thanks for the references, that is helpful.
While there are some patches in those repos that I can (and will) apply, most of the patches in those distro packages are generally not up to the standard that I want:
* They usually don't have any authorship information or Signed-off-by line * They usually don't have any description at all explaining what is being fixed or why this is a good change to make(The openwrt patches do seem to be better than most in these respects.)
@bootc @yarda @nbd168
Added current maintainers to the thread: Chris Boot(debian), Jaroslav Škarvada(fedora) and Felix Fietkau(openwrt)
First it would be good to make new release ASAP with what is already commuted. Better do some progress in some more frequent but smaller steps :)
Problem is so far maintainer is not responding (hopefully he is just only busy :) )
@bootc (Debian), @yarda (Fedora), @nbd168 (OpenWrt), @dmbaturin (VyOS) and others: Guys, can you create a PR with your patches?
It will be nice to have directly in the next build?
Thanks in advance.
@Neustradamus #101 is the only remaining significant difference between our package and the upstream.
Dear all,
I think, it is time to speak about all your patches in your OS. Several OS have same patches... Talk here, and can you see to create a PR by patch?
Please verify before if it is not already here, and if yes, please comment to inform that it is needed and specify the period used:
- https://github.com/paulusmack/ppp/pulls
- https://github.com/paulusmack/ppp/issues
Note: https://github.com/paulusmack/ppp/blob/master/Submitting-patches.md
Thanks in advance.
Adélie Linux: @awilfox
- https://code.foxkit.us/adelie/packages/blob/master/user/ppp/APKBUILD
Alpine Linux: @ncopa / @kaniini
- https://github.com/alpinelinux/aports/tree/master/main/ppp
- https://git.alpinelinux.org/aports/tree/main/ppp?h=master
- https://pkgs.alpinelinux.org/packages?name=ppp
ALT Linux: @shaba
- http://git.altlinux.org/gears/p/ppp.git
- https://github.com/vt-alt/specs/tree/master/p/ppp
- https://packages.altlinux.org/en/p9/srpms/ppp + https://packages.altlinux.org/en/p9/specfiles/ppp
- https://packages.altlinux.org/en/sisyphus/srpms/ppp + https://packages.altlinux.org/en/sisyphus/specfiles/ppp
Arch Linux: @foutrelis, @antonio-rojas, @felixonmars, @allanmcrae
- https://archlinux.org/packages/core/x86_64/ppp/
- https://archlinux.org/packages/core-testing/x86_64/ppp/
- https://gitlab.archlinux.org/archlinux/packaging/packages/ppp
AUR (Arch Linux User Repository):
- @mrjackv: https://aur.archlinux.org/packages/ppp-debian/
- @Chocobo1 (not sure): https://aur.archlinux.org/packages/ppp-git/
AUR (Arch Linux User Repository) (Other):
- @yay6: https://aur.archlinux.org/packages/ppp-eap-tls/ (Now in master)
- https://aur.archlinux.org/packages/ppp-eap-mschapv2/ (Now in master)
Debian: @sthibaul + @bootc
- https://salsa.debian.org/debian/ppp
Entware: @zyxmon + @The-BB + @ryzhovau
- https://github.com/Entware/Entware/tree/master/package/network/services/ppp
Fedora: @yarda + @msekletar
- https://src.fedoraproject.org/rpms/ppp/tree/master
Gentoo: @Polynomial-C
- https://github.com/Polynomial-C/ppp/tree/2.4.8-gentoo
- https://github.com/gentoo/gentoo/tree/master/net-dialup/ppp
- https://packages.gentoo.org/packages/net-dialup/ppp
KaOS: @demmm
- https://kaosx.us/packages/packages.php?sortby=&sortdir=&flagged=&page=&repo=&exact=&search=ppp
- https://github.com/KaOSx/core/blob/master/ppp/PKGBUILD
KISS Linux: @onodera-punpun
- https://github.com/kisslinux/community/tree/master/community/ppp
OpenEmbedded / Yocto: @rpurdie + @jku + @jackiehjm + @hongxu-jia + @ChenQi1989 + @bluelightning + @shr-project + @mtdcr + @rpjday + @koenkooi + @yoctopidge + @kanavin + @yizhao1 + @kraj + @rossburton + @jekhor + @saulwold + @mhatle
- https://layers.openembedded.org/layerindex/recipe/793/
- https://github.com/openembedded/openembedded-core/tree/master/meta/recipes-connectivity/ppp
OpenMandriva: @tpgxyz + @berolinux
- https://github.com/OpenMandrivaAssociation/ppp
OpenSUSE: @rma-x + @IlyaIndigo + @DimStar77 + @pgajdos + @andreasstieger + @andreas-schwab + @thkukuk
- http://rpmbase.ru/linux/RPM/opensuse/ports/tumbleweed/ppc64/ppp-2.4.8-1.1.ppc64.html
- https://software.opensuse.org/package/ppp
- https://build.opensuse.org/package/show/openSUSE%3AFactory/ppp
- https://build.opensuse.org/package/show/openSUSE%3ALeap%3A15.2/ppp
Rosa: @fedya + @andrewlukoshko
- https://abf.io/import/ppp
SliTaz: @pankso + @lexeii
- https://github.com/SliTaz-official/wok-stable/tree/master/ppp
- https://github.com/SliTaz-official/wok-stable/tree/master/ppp-dev
- https://github.com/SliTaz-official/wok-stable/tree/master/ppp-pam
- https://github.com/SliTaz-official/wok-tiny/tree/master/ppp
- https://github.com/SliTaz-official/wok-tiny/tree/master/ppp-plugins-atm
- https://github.com/SliTaz-official/wok-tiny/tree/master/pppdump
- https://github.com/SliTaz-official/wok-tiny/tree/master/pppstats
- https://github.com/SliTaz-official/wok/tree/master/ppp
- https://github.com/SliTaz-official/wok/tree/master/ppp-dev
- https://github.com/SliTaz-official/wok/tree/master/ppp-pam
- https://github.com/SliTaz-official/wok-next/tree/master/ppp
Solus: @JoshStrobl
- https://dev.getsol.us/source/ppp/
- https://dev.getsol.us/source/ppp/browse/master/
T2 SDE: @rxrbln:
- http://t2sde.org/packages/ppp
Ubuntu: @bootc + @andigor
- https://bugs.launchpad.net/ubuntu/+source/ppp
VyOS: @dmbaturin
- https://github.com/vyos/ppp-debian
Repology:
- https://repology.org/project/ppp/packages
I do not have a desire to do PR for the project, where PRs have been hanging for more than 6 years. To the author of the ppp, apparently. they are not needed at all.
@Neustradamus For the record, our "ppp-debian" repo is just Debian's upstream with the patch from #101 and some misc security fixes that are already offered in other PRs. Once #101 is merged we'll be able to switch to the upstream version.
@IlyaIndigo This is a rather uncomfortable discussion, but I do believe that if Paul doesn't have time and motivation to maintain the package, he should add someone to the repo owners. In the current situation, I can't see any of the semi-forks becoming a new de facto standard—none of them has enough momentum by itself.
In new VyOS releases, we switched from pppd to https://github.com/xebd/accel-ppp for the L2TP/PPTP/PPPoE servers: it offers great performance and it has maintainers passionate about it. I'm pretty sure there's someone equally passionate about the original ppp who can take up the maintenance work, given enough permissions to do that.
OpenSUSE:
* Reinhard Max (Not found on GitHub) + @IlyaIndigo + @DimStar77 + @pgajdos + @andreasstieger + @andreas-schwab + @thkukuk: http://rpmbase.ru/linux/RPM/opensuse/ports/tumbleweed/ppc64/ppp-2.4.8-1.1.ppc64.html * https://software.opensuse.org/package/ppp
I have notified Reinhard about this issue.
