aws-sdk-perl icon indicating copy to clipboard operation
aws-sdk-perl copied to clipboard
verified publisher icon pplu

WIP: Ignore provided 'region' if 'credentialScope' is defined

Open meis opened this issue 7 years ago • 2 comments

If we end in a rule with 'credentialScope', we probably want to ignore the 'region' even if the user has defined one.

Request to rules with 'credentialScope' are only going to succeed with the region in it, so if the user (mistakenly or not) has a 'region' defined the request will fail.

It may be nice, though, to leave a WARNING if 'region' is defined and is different from the one in 'credentialScope'.

meis avatar Jun 20 '18 14:06 meis

Hi,

I've imported the branch so travis runs the full test suite: it looks like the code was there to let the user specify with what region to sign when a custom endpoint is specified. t/06_endpoint_override.t is failing https://travis-ci.org/pplu/aws-sdk-perl/branches

pplu avatar Jun 20 '18 19:06 pplu

I've added a new commit that AFAIK greens everything again.

I'm not really sure if you want to do this, tho. I don't like the hacky approach but I'm really not familiar with the codebase to come up with a better solution. Maybe it's a problem we don't need to solve.

Give it a glance and maybe we can discuss it at some point.

meis avatar Jun 21 '18 17:06 meis