redmine-libsvn icon indicating copy to clipboard operation
redmine-libsvn copied to clipboard

Fix for broken empty repository view

Open DeX77 opened this issue 14 years ago • 3 comments

Guess this is a typical off-by-one error

DeX77 avatar Jan 26 '11 21:01 DeX77

The fix didnt work for me, although i was having issues with Svn::Error::FsNotFound on a repository created after 200th revision.

Simply added a rescue Svn::Error::FsNotFound to the rescue block on the revisions method, which seems to have fixed the issue for me

nakchak avatar Feb 10 '11 11:02 nakchak

Thx for trying it! I'm sorry to hear it didn't help. Anyway I think your issue might not be related to my change? To ignore Errors doesn't sound like the way to go for me, either.

DeX77 avatar Feb 10 '11 19:02 DeX77

I agree, i would rather handle it annother way, but the root of my problem came from how the repository is structured, as we have about 50 projects running out of one repo, so "root" project folders often have an initial revision number of several thousand when they are new projects in the repo. Initially i was seeing the problem with an empty folder hence trying the fix.

Given how the libsvn plugin is called from the core repo interface code, it would be impractical to modify core functionality to work with a reverse log rather than iterating from 1 to head revision for a given project, so in this case catching the FsNotFound seems an acceptable solution, also would seem to fix a lot of the issues posted here regarding server 500 errors, as i assume many people use svn in a similar manner to how its been set up where i work. Hopefully i can push through the adoption of the model used by collabnet subversion edge, which uses the repo per project structure. But right now that isnt an option.

Nice DoTT avatar btw :-)

nakchak avatar Feb 10 '11 20:02 nakchak