ppigazzini

Results 323 comments of ppigazzini

Ok, not considered the timeline, so also the first `api_stop_run` is a mystery (if we are logging the time in the same timezone).

I will be away from the keyboard for some hours, no time to check now. I'm wondering if that worker reported the error after a connection problem (if I recall...

We are doubling over and over `sleep(delay)` for any exception raised in `games()`, eg `Exception accessing host:` https://github.com/glinscott/fishtest/blob/278a946a191fed9e2d45f5258b0fd93c846dc382/worker/worker.py#L504-L511 https://github.com/glinscott/fishtest/blob/278a946a191fed9e2d45f5258b0fd93c846dc382/worker/worker.py#L229-L238 BTW we are doubling `sleep(delay)` also when the queue is empty......

The worker: 1. downloads test src, test nn and compiles test 2. downloads base src, base nn and compiles base 3. download cutechess-cli 4. download book 5. check benches for...

I don't understand what the `failed_task` api does, we call it after a successful `games()` call too. From `git blame` that logic is 9 years old. (BTW we should drop...

EDIT_000: `finally:` clause is executed no matter what, and is generally used to release external resources. https://github.com/glinscott/fishtest/blob/278a946a191fed9e2d45f5258b0fd93c846dc382/server/fishtest/rundb.py#L32 https://github.com/glinscott/fishtest/blob/278a946a191fed9e2d45f5258b0fd93c846dc382/server/fishtest/rundb.py#L955-L960 https://github.com/glinscott/fishtest/blob/278a946a191fed9e2d45f5258b0fd93c846dc382/server/fishtest/rundb.py#L978-L980 Now `DEBUG = False` so the log has: ``` Oct 11...

Ops, sorry, multitasking here, missed the different subject and missed that "Inactive:" is sparse, it shows up using grep. ``` sudo journalctl -u fishtest@6543 --since "1 days ago" | grep...

The "Inactive:" log entry changed between 2021-09-11 and 2021-09-11 ([dynamic task](https://github.com/glinscott/fishtest/commit/29983d0349f1879fd937ed92009ce8429b496faf)?): ``` sudo journalctl -u fishtest@6543 --since "2021-09-11 00:00:00" --until "2021-09-11 23:59:59" | grep "Inactive:" | wc -l 12755 sudo...

> In other words. Calling `failed_task` after a task that completed normally is harmless but also useless. Good, we could retire that api. Thanks for the behavior analysis! ``` sudo...

I wish you way more than luck @Dantist