swiftp icon indicating copy to clipboard operation
swiftp copied to clipboard

Remove twofortyfouram to fix broken builds (one possibility)

Open Xavron opened this issue 1 year ago • 3 comments

If you want to go this way to fix the issue, then its here. I'd rather give you something instead of nothing. I won't likely be doing anything else for this so you'd have to if you want to go a different way.

o Removed fortytwofouram due to breaking the builds.

  • Possible fix for issue https://github.com/ppareit/swiftp/issues/245

The choice is yours :)

Xavron avatar Aug 28 '24 22:08 Xavron

Yes build is broken, this should be merged !

constambeys avatar Oct 13 '24 06:10 constambeys

Also the grandle properties needs to be checked is using some weird settings like

-org.gradle.unsafe.configuration-cache=true -android.nonTransitiveRClass=false -android.nonFinalResIds=false

constambeys avatar Oct 13 '24 06:10 constambeys

Also the grandle properties needs to be checked is using some weird settings like

-org.gradle.unsafe.configuration-cache=true -android.nonTransitiveRClass=false -android.nonFinalResIds=false

Oh. If I'm looking at that right, ~it looks to be already in there: https://github.com/ppareit/swiftp/blob/master/gradle.properties~

~All I know is that I didn't think about it :)~

Edit: I wasn't looking at it right lol. Looks like it showed up with commit 221cc02148e9864789cccd36a06a8d08a3f1e34e and is a separate issue. Not related to this pull request. At least the unsafe cache is now outdated: https://docs.gradle.org/8.1/userguide/upgrading_version_8.html#configuration_caching_options_renamed but this should be dealt with elsewhere.

Edit: Still missed one lol. This commit was the unsafe cache https://github.com/ppareit/swiftp/commit/0fa98cd18397852f162f33e729ada22b8735ec6c

Xavron avatar Dec 09 '24 00:12 Xavron