swiftp
swiftp copied to clipboard
ppareit
easy fix to allow selecting the root SD card volume
I'm confused. Did this not work on older Android versions? I see you changed some of the recent scoped storage code and Android 13 (or more correctly scoped storage on recent Android versions) done properly will not allow sd card root to be used.
I didn't test your changes here though and there's too many to know what the end result is which is why I'm asking what was going on here.
Oh I see. You're trying to get ACTION_MANAGE_APP_ALL_FILES_ACCESS_PERMISSION into here. That's something Pieter will want to figure out. I'm not getting involved in this one lol. (Yeah, I know, already am a little :)P
Intent intent = new Intent(Settings.ACTION_MANAGE_APP_ALL_FILES_ACCESS_PERMISSION);
See here why its not allowed by the Play Store: https://support.google.com/googleplay/android-developer/answer/10467955?hl=en
A separate branch would probably be better. Google is very likely to deny approval of it for the app. And scoped storage is already implemented and working as its intended to work by Android. Of course if Pieter can get approval for it that would be cool. That's not my experience with it however lol.
Seems like the perfect functionality for the f-droid version. The play-store version cannot have this.
Ok maybe is safer for the user to grant specific directory permissions !!!
I'll keep this open. I do like this modification. But only for f-droid version.
Your fix allows SwiFTP to be used in the spirit that it was written for. Access to all files on the device.