graphviz-dot-mode icon indicating copy to clipboard operation
graphviz-dot-mode copied to clipboard

font-lock-reference-face has been removed from Emacs

Open ericsfraga opened this issue 2 years ago • 4 comments

This face had been marked as obsolete for some time, I guess, and it has now been removed from the development version of Emacs. Solution is to use a different font lock face, I guess, but I have no idea which one would be most relevant.

ericsfraga avatar Aug 05 '22 13:08 ericsfraga

Thanks for the heads up!

Would not mind a PR.

ppareit avatar Aug 07 '22 09:08 ppareit

You're welcome and, okay, I'll see if I can do something this week.

ericsfraga avatar Aug 08 '22 11:08 ericsfraga

Found some time today. I am not au fait with pull requests etc. so I'll suggest the change required here. There is only one line affected, line 559 of graphviz-dot-mode.el. I would suggest changing that line to . font-lock-constant-face) I was going to suggest using font-lock-keyword-face but you are already using that.

ericsfraga avatar Aug 08 '22 15:08 ericsfraga

Seem a good substitution.

ppareit avatar Aug 16 '22 13:08 ppareit

Thanks for spotting this @ericsfraga! This was causing org-babel fontification errors in case of source blocks with options in them, such as this one:

#+begin_src dot
digraph {
  rankdir=LR
  a->b
}
#+end_src

I made a PR with your suggested fix.

@ppareit Hartelijk bedankt voor deze prachtige Emacs modus! :) 🙏 💯

epost avatar Jan 26 '23 23:01 epost

Perfect. I'm pulling this right now. Thanks to both!

ppareit avatar Jan 27 '23 10:01 ppareit

Excellent. Thank you!

ericsfraga avatar Jan 27 '23 10:01 ericsfraga