Patrick Peglar
Patrick Peglar
All the grib2 load rules in `iris_grib._load_convert` are written in terms of the sectionally-structured `GribMessage` object. But all the **save** rules (`iris_grib._save_rules`) use the gribapi (and/or eccodes) instead **Technical Debt...
Especially Ruff, but also repo-review (when integrated) We can adopt the general approach [developed for ruff in Iris](https://github.com/SciTools/iris/issues/5625#issuecomment-1859159734), broadly - a to-do checklist of excluded checks - a regular review...
The [translation routine for gdt 3.10 (mercator grids)](https://github.com/SciTools/iris-grib/blob/v0.15.0/iris_grib/_load_convert.py#L755) does not check all termplate parameters. Specifically, it doesn't check the scanningMode, nor *any* of the following parameters at the end of...
Probably lose the test runner **Ideally** migrate to pytest : #253
See [here](https://github.com/SciTools/iris-grib/blob/v0.19.x/iris_grib/_save_rules.py#L233-L250) and [here](https://github.com/SciTools/iris-grib/blob/v0.19.x/iris_grib/_save_rules.py#L331-L343) There might be others ?
Progress towards new releases, and "when will my fix come" could certainly be clearer.
Example... ``` >>> filename = "...iris-test-data/test_data/GRIB/grib1_second_order_packing/GRIB_00008_FRANX01" >>> from iris_grib import _load_generate >>> fields_iter = _load_generate(filename) >>> fields = list(fields_iter) >>> fields[0].qqq Segmentation fault ``` Originally looked like a problem with...
IMHO we should be rounding ***any*** time we convert a float value to a scaled integer. While making a fix in #210, I scanned the whole of `save_rules.py` for "`int(`"...
If you search for uses of `_STATISTIC_TYPE_NAMES`within `iris_grib.save_rules`, it seems that `product_definition_template_15` accesses it via the helper function `statistical_method_code`, which also raises an error about unsupported. However, `_product_definition_template_8_10_and_11` uses the...
To be considered .. * setuptools-scm for version management * GHA for automated package builds * GHA not Cirrus for tests * ruff etc ?? Basically steal ideas from other...