Patrick Peglar
Patrick Peglar
@lbdreyer I hope recent commits should cover a lot of your outstanding comments. But a couple of things are clearly still outstanding * whether I should be [testing load- and...
Updates ... > @lbdreyer ... a couple of things are clearly still outstanding > * whether I should be [testing load- and save behaviours independently of a round-trip approach](https://github.com/SciTools/iris/pull/4960#discussion_r987733199) I...
I think this is okay to review now. A couple of notes though ... (1.) I ended up doing two different things here : * (a) fix the name loaders...
@volcan01010 would you be available to review ?
> This looks good to me, I had one small comment though. > > It is a bit of a shame there is no extra testing for the name loader...
> None of the existing test files seem suitable. I did test it on a modified version of one of the existing test files, but the problem is I can...
OK, I confused myself there. There is no such pre-existing file in iris-test-data, only in my version ! I will fix this, and perhaps now revert all the file moves...
This should pass, once https://github.com/SciTools/iris-test-data/pull/82 is merged (unless some other update is merged there first)
Many thanks @bsherratt Working slightly in the dark here, as don't actually know much about NAME, so help is welcome ! > Can this PR please also be added as...
Yay, GTG ! with thanks, Merges invited ? ...