github-dark-theme icon indicating copy to clipboard operation
github-dark-theme copied to clipboard

dark theme for contributions

Open RootOperator opened this issue 6 years ago • 9 comments

add dark theme for contributions like this color code here is #404751

RootOperator avatar Nov 10 '19 13:11 RootOperator

plus the legend too

Screenshot 2019-11-26 07 38 33

chancesmith avatar Nov 26 '19 13:11 chancesmith

I'd like to take a stab at this one. 🙋‍♂️

chancesmith avatar Nov 26 '19 13:11 chancesmith

#41 was discuss this feature. Using darker color present less contributions is confusing some of developers. So I keep it on original style. But I still open on this issue.

poychang avatar Nov 28 '19 02:11 poychang

I know there's been a lot of flip-flopping for the order the scale should go. The screenshot above starts dark then goes light to dark. IMO, it should entirely go from dark to light. Or more accurately it goes from least contrast to the background to highest contrast which is consistent when viewing in the normal light mode. contribs

$contrib-color: #103605;
$contrib-color-1: $block-bg;
$contrib-color-2: $contrib-color;
$contrib-color-3: lighten($contrib-color, 15%);
$contrib-color-4: lighten($contrib-color, 30%);
$contrib-color-5: lighten($contrib-color, 50%);

ammmze avatar Dec 19 '19 02:12 ammmze

I like this color scheme! And I don't think it's confusing, but I wasn't confused the first time around either :) There is a legend in the bottom right that shows Less to More.

I think we should re-implement this, since it's one of the last places that is not inverted.

tariq86 avatar Dec 26 '19 14:12 tariq86

add dark theme for contributions like this color code here is #404751

Definitely prefer this color over the others suggested. Contrasts with all of the >0 contribution days while still maintaining contrast with the background.

gerpsh avatar Jan 17 '20 17:01 gerpsh

Any updates on this issue? I'd like to see the color scheme in the screenshot being implemented.

arnavb avatar Mar 23 '20 01:03 arnavb

Would love to see this make it in as well

esatterwhite avatar Apr 29 '20 22:04 esatterwhite

I want to end this series of discussions with this color #31363f shows below. This color is block background color of this theme. I think it makes sense for the color set of this theme. And also keep original green contribution color to let no people confusing.

image

If you support this adjust, please thumb this up. I'll merge this into master when getting 10 thumbs. Thank you!

poychang avatar Jun 05 '20 01:06 poychang