github-dark-theme icon indicating copy to clipboard operation
github-dark-theme copied to clipboard

GitHub released a dark theme

Open thgh opened this issue 4 years ago • 15 comments

https://github.com/settings/appearance

thgh avatar Dec 08 '20 22:12 thgh

I don't really why this should've been posted as an issue.

IamCathal avatar Dec 08 '20 22:12 IamCathal

Even though I will stop using the extension from now on, I think this issue is a good opportunity to thank all the contributors for the top-quality work they've done here and for giving our eyes a rest on github until now. Cheers !

BlueInt32 avatar Dec 09 '20 05:12 BlueInt32

I found that the new official dark theme has way too much contrast. This extension looks much better. I'm also really thankful for all the work so far, and will continue to use the extension on top of the new dark theme.

lopis avatar Dec 09 '20 10:12 lopis

Will not stop using the extension as well... Background is softer and buttons in white are much better than in BLUE.

Good thing about having the official Dark Theme available, is that, this extension can get some inspiration on what has been done by the GitHub team and still improve on top of it!

Maybe adding some of the colors and schemes from the new code diff page.

Everything else is still better in the extension, in my opinion.

mauriciotasca avatar Dec 09 '20 16:12 mauriciotasca

The problem is that it doesn't work when you're not logged on the github though the extension works (of course).

WPMGPRoSToTeMa avatar Dec 12 '20 12:12 WPMGPRoSToTeMa

I think the extension is looking much better than GitHub's own dark theme, could also be because it's still in beta.

Code syntax highlighting is the main reason I like the extension a lot more, GitHub's syntax highlighting being very poor, at least for C# code.

Compare: https://github.com/Laiteux/Milky/blob/v3/src/Milky/Checker.cs

Laiteux avatar Dec 16 '20 02:12 Laiteux

In my case, I'll turn on official dark theme and go with this extension. It works fine for most of situation. Thanks for GitHub made their original dark theme. I hope one day their will release custom feature. Thanks for all the developer who support/contribute this extension. 😀

here to turn on official dark theme 🌚

poychang avatar Jan 23 '21 02:01 poychang

This theme is far better than github theme, if you are spending quality time with github and using this theme since long. I am on Dell XPS retina display and feel the positive effect of this theme.

  1. grey contrast - > better reading
  2. blue folders -> file focus
  3. different grey contrast for file explorer gives you focus on code explorer directly.
  4. etc. etc.

Overall thanks for making this theme ahead of time. Still better than github dark theme & would be continuing with this. I would be happy if github can provide customisation, so that I can create same theme with that.

AmreeshTyagi avatar Mar 12 '21 01:03 AmreeshTyagi

GitHub has new dark theme, Dark dimmed. This one looks really nice. Everyone can give a try. I believe their will support enterprise domain in near future.

poychang avatar Mar 17 '21 15:03 poychang

With the new github theme, I think I can finally remove this extension. It was a great run. Thank you so much @poychang for the support.

lopis avatar Mar 17 '21 15:03 lopis

But the funny thing is that this extension is still a better theme than the official one. The official dark modes are either too light, or too dark.

lopis avatar Mar 18 '21 08:03 lopis

@poychang tried new Dark dimmed theme as well today. Not very much readable in low brightness. Text color can be more brighter. My screen brightness is adaptive and usually I work with just night lamp in my room during late night. Github new theme is still not useful for me in this case. Your theme is still better. :)

Good efforts by github team.

AmreeshTyagi avatar Mar 18 '21 17:03 AmreeshTyagi

This plugin is definitely still useful for out-of-date GitHub Enterprise instances where we don't have the GitHub themes yet.

connorjak avatar Apr 20 '21 08:04 connorjak

image

  • github.com/explore doesn't use github's official dark theme
  • this repo was at the top of Explore

The irony

glibg10b avatar May 01 '21 18:05 glibg10b

Ya, I still like this theme better. I turn on the github dark dimmed, and also apply this theme. The end result is :ok_hand:

esatterwhite avatar Dec 31 '21 15:12 esatterwhite