github-dark-theme icon indicating copy to clipboard operation
github-dark-theme copied to clipboard

Published 20 hours ago • verified publisher icon poychang

Dark theme is not applied around `input`/`textArea`

Open kittaakos opened this issue 3 years ago • 8 comments

See the attached images. Note, the markdown preview is also broken :( The GH guys must have changed something:

Screen Shot 2020-10-26 at 09 04 25 Screen Shot 2020-10-26 at 09 03 54 Screen Shot 2020-10-26 at 09 07 02

Thank you for the great lib ❤️

kittaakos avatar Oct 26 '20 08:10 kittaakos

Are you running v1.1.16? As I believe this was fixed in #275

RedSparr0w avatar Oct 27 '20 20:10 RedSparr0w

It's fixed in the latest release, but it looks like the latest version available for Firefox is 1.1.13:

no-updates-found

tariq86 avatar Oct 27 '20 22:10 tariq86

Are you running v1.1.16?

Yes. I was running with 1.1.16. It works with 1.1.17 in Brave. 🎉

I'd propose closing this issue and track the FF-specific version thing separately but it's the maintainer's call 😊

kittaakos avatar Oct 28 '20 08:10 kittaakos

The Firefox extension stopped at version 1.1.13 because the package platform blocked my release. They require uploading the source code to release the package. Even this is open source project. Currently I can only upload manually, if anyone knows how to upload the source code automatically, please let me know, thank you very much.

poychang avatar Oct 28 '20 10:10 poychang

I thought you only need to upload the source code if the code is minified? But it looks like the FireFox version already has minification disabled..

RedSparr0w avatar Oct 29 '20 01:10 RedSparr0w

@RedSparr0w Yes, it's already disable minification for firxfox. But according this, if use build tools like browserify or webpack, must upload source code. That's the issue.

poychang avatar Oct 29 '20 02:10 poychang

Can you do a manual upload once so that a recent version is available on Firefox Addons and then tackle automatic updates in a separate issue?

foss- avatar Nov 03 '20 10:11 foss-

@foss- I did that. Wait for approval from them.

poychang avatar Nov 03 '20 11:11 poychang