pypowsybl icon indicating copy to clipboard operation
pypowsybl copied to clipboard

add missing attributes for per unit view

Open EtienneLt opened this issue 1 year ago • 3 comments

Please check if the PR fulfills these requirements

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • [ ] Yes
  • [ ] No

If yes, please check if the following requirements are fulfilled

  • [ ] The Breaking Change or Deprecated label has been added
  • [ ] The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

EtienneLt avatar Feb 20 '24 15:02 EtienneLt

Did you check that all attributes that are now accessible are correctly per-united? For example target_v for transformer 2 and 3, shunt ? Also all target p and q (hvdc lines etc ) ?

I will add some tests

EtienneLt avatar Feb 22 '24 08:02 EtienneLt

Did you check that all attributes that are now accessible are correctly per-united? For example target_v for transformer 2 and 3, shunt ? Also all target p and q (hvdc lines etc ) ?

well all targetv for transformer and target p ans q for hvdc are default attributes so they were already perunit I added the non default attributes for generators and vsc stations (max_q_at_p, ....)

EtienneLt avatar Feb 22 '24 08:02 EtienneLt

update_ratio_tap_changers is missing

EtienneLt avatar Feb 22 '24 08:02 EtienneLt