pypowsybl icon indicating copy to clipboard operation
pypowsybl copied to clipboard

[Network modifications] Create voltage level topology from scratch.

Open colinepiloquet opened this issue 2 years ago • 1 comments

Signed-off-by: Coline PILOQUET [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [x] The commit message follows our guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Wraps CreateVoltageLevelTopology from powsybl-core. It allows to create a symmetrical voltage level from scratch, by specifying the number of busbar sections, the number of sections and the switch kind between sections.

Other information: For now, I did not write the documentation. I will create a dedicated PR with fixes, and documentation about all the network modification as it will be clearer to explain. (branch creation, coupling device creation + this PR)

colinepiloquet avatar Nov 29 '22 16:11 colinepiloquet

Could you add new methods in network.rst ? I think it is missing

EtienneLt avatar Dec 02 '22 10:12 EtienneLt

@EtienneLt, new design for all the network modifications. What do you think? For now I only put the creation of a voltage level but it should apply to all the modifications.

colinepiloquet avatar Jan 10 '23 09:01 colinepiloquet

@EtienneLt, new design for all the network modifications. What do you think? For now I only put the creation of a voltage level but it should apply to all the modifications.

I think it is quite good, just I think we should add subfolders in java/src/main/java/com/powsybl/dataframe/network/adders/ something like modification and creation (if you have a better idea) There minor details to change too

EtienneLt avatar Jan 10 '23 10:01 EtienneLt

There should not be any change in cpp/lib/pybind11

EtienneLt avatar Jan 10 '23 10:01 EtienneLt