pypowsybl icon indicating copy to clipboard operation
pypowsybl copied to clipboard

[WIP] Draft of new layout for python modules

Open sylvlecl opened this issue 2 years ago • 1 comments

Signed-off-by: Sylvain Leclerc [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [X] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

#300

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Refactoring

sylvlecl avatar Jun 28 '22 14:06 sylvlecl

@geofjamg @EtienneLt @CBiasuzzi @massimo-ferraro @obrix :

please do not hesitate to formulate a critical opinion on this proposed layout (implemented on loadflow module only as an illustration): all actual code goes into impl subpackage, while the public API is simply defined by importing the classes and methods we want to expose.

This should allow to scale better (more python files, basically ...), and to not care too much about namespace pollution in implementation files.

sylvlecl avatar Jul 06 '22 16:07 sylvlecl

done with https://github.com/powsybl/pypowsybl/pull/641

EtienneLt avatar Aug 31 '23 15:08 EtienneLt