powsybl-open-loadflow icon indicating copy to clipboard operation
powsybl-open-loadflow copied to clipboard

Bump to iidm OverLoadManagementSystem

Open jeandemanged opened this issue 1 year ago • 2 comments

Please check if the PR fulfills these requirements

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

OLF has its own iIDM extension to describe automation systems

What is the new behavior (if this is a feature change)? Remove OLF iIDM extension, use powsybl-core new automation systems available in iIDM v1.12 (see https://github.com/powsybl/powsybl-core/pull/2779)

Does this PR introduce a breaking change or deprecate an API?

  • [ ] Yes
  • [ ] No

If yes, please check if the following requirements are fulfilled

  • [ ] The Breaking Change or Deprecated label has been added
  • [ ] The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

jeandemanged avatar Jan 05 '24 12:01 jeandemanged

Quality Gate Failed Quality Gate failed

Failed conditions
88.3% Coverage on New Code (required ≥ 90%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 20 '24 09:02 sonarqubecloud[bot]

Thanks @jeandemanged ! Three-windings transformer missing, to be done in another PR.

Thanks @annetill @geofjamg ! :), sounds good for me!

jeandemanged avatar May 14 '24 16:05 jeandemanged

Quality Gate Failed Quality Gate failed

Failed conditions
89.3% Coverage on New Code (required ≥ 90%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 15 '24 06:05 sonarqubecloud[bot]