powsybl-open-loadflow icon indicating copy to clipboard operation
powsybl-open-loadflow copied to clipboard

Test Metrix for violations in Current, Voltage, Active and Apparent Power

Open caioluke opened this issue 2 years ago • 1 comments

ADD: Test Metrix for violations in Current, Voltage, Active and Apparent Power.

Signed-off-by: cluke [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • [ ] The Breaking Change or Deprecated label has been added
  • [ ] The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

caioluke avatar Nov 14 '22 16:11 caioluke

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 14 '22 16:11 sonarqubecloud[bot]

What is the status of this PR?

geofjamg avatar Mar 02 '23 13:03 geofjamg

What is the status of this PR?

As I said in my comment, this should be done in a dedicated factory in order to be reusable. And the good practice is to find relevant values without any characterictics change.

annetill avatar Mar 02 '23 18:03 annetill

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 05 '23 09:04 sonarqubecloud[bot]