powsybl-open-loadflow [WIP] Fix non impedant phase shifter with active power flow control activated

Signed-off-by: Geoffroy Jamgotchian [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix

What is the current behavior? (You can also link to an open issue here) If a phase shifter is non impedant or has a low impedance and that regulation is activated, we get an exception

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

[ ] The Breaking Change or Deprecated label has been added
[ ] The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Nov 04 '22 11:11 geofjamg

@annetill @Hadrien-Godard what is the best way to fix this? I would say non or low impedance phase shifter should not be modelled as perfect non impedant branches as for this kind of branch we cannot calculate the flow during calculation (just as a post processing) and so on we cannot target a specific flow or detect a current violation. So for theses specific pĥase shifters, we should just use a min impedance even if mode is REPLACE_BY_ZERO_IMPEDANCE_LINE.

Nov 04 '22 12:11 geofjamg

@annetill @Hadrien-Godard what is the best way to fix this? I would say non or low impedance phase shifter should not be modelled as perfect non impedant branches as for this kind of branch we cannot calculate the flow during calculation (just as a post processing) and so on we cannot target a specific flow or detect a current violation. So for theses specific pĥase shifters, we should just use a min impedance even if mode is REPLACE_BY_ZERO_IMPEDANCE_LINE.

I am ok with proposed solution. If the non impedant part is limited to only one branch, it may be possible to keep the perfect non impedant branch, as the DUMMY_P variable introduced for the branch represents the active flow on the branch and can be used into the power control.