powsybl-open-loadflow icon indicating copy to clipboard operation
powsybl-open-loadflow copied to clipboard

Published 20 hours ago • verified publisher icon powsybl

Improve coupler detection

Open flo-dup opened this issue 3 years ago • 3 comments

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? Yes, fixes #333

flo-dup avatar Jul 16 '21 12:07 flo-dup

There's no so clean way to do it yet but still, the whole traverser is stopped if a terminal which is not a busbar is encountered

flo-dup avatar Jul 28 '21 14:07 flo-dup

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.9% 97.9% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 29 '21 08:07 sonarqubecloud[bot]

As @sylvlecl said in the issue, detecting couplers is probably not enough for identifying the contingencies that we cannot simulate correctly for now in open-loadflow. For instance, the network in PropagatedContingencyTest::testSwitchConnectedTo2wtAndBusbar cannot be simulated properly due to the "B5" switch, which is not detected as a coupler, as it is connected to a busbar on one side, and on a busbar and a transformer on the other side

flo-dup avatar Jul 29 '21 08:07 flo-dup