powsybl-diagram icon indicating copy to clipboard operation
powsybl-diagram copied to clipboard

Published 20 hours ago • verified publisher icon powsybl

Running the layout is not idempotent

Open flo-dup opened this issue 3 years ago • 3 comments

  • Do you want to request a feature or report a bug? Bug

  • What is the current behavior? Running the layout is not idempotent

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem Running twice the layout on the same Diagram object leads to ugly glitches (wider cells, floating internal nodes, margins between voltage levels wider, ....)

  • What is the expected behavior? Running twice the layout on the same Diagram object leads to the same SVG file

  • What is the motivation / use case for changing the behavior? Fixing a bug

  • Please tell us about your environment: PowSyBl Version: core 4.4.0 and sld 2.4.0

flo-dup avatar Oct 15 '21 11:10 flo-dup

This does not really occur anymore, as it is not possible to run twice the layout directly with the new SingleLineDiagram interface. Nonetheless, the behaviour is not normal and should be investigated further

flo-dup avatar Jan 05 '22 14:01 flo-dup

This does not really occur anymore, as it is not possible to run twice the layout directly with the new SingleLineDiagram interface. Nonetheless, the behaviour is not normal and should be investigated further

But we cannot suppose that everybody will use SingleLineDiagram. This is just a convenient utility class.

geofjamg avatar Jan 05 '22 14:01 geofjamg

Yes, in fact that's what I meant by saying "not really".

flo-dup avatar Jan 05 '22 14:01 flo-dup