powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

Add tgz option to packager

Open gverger opened this issue 1 year ago • 2 comments

Please check if the PR fulfills these requirements

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

This PR adds an option for the packager to use a tar.gz compressor instead of zip. Zip is still the default.

What is the current behavior?

There is currently no option to chose the file type when packaging itools, it is zipped.

What is the new behavior (if this is a feature change)? A new option in the maven plugin allows for compressing with tar gz.

Does this PR introduce a breaking change or deprecate an API?

  • [ ] Yes
  • [x] No

Other information:

I don't know how to test this. The only thing I did was testing on our project depending on powsybl-core.

gverger avatar Oct 07 '24 12:10 gverger

thanks, tested manually/locally on my side and works good, @olperr1 let us know if you have ideas about automated testing of this maven plugin ...

jeandemanged avatar Oct 08 '24 12:10 jeandemanged

thanks, tested manually/locally on my side and works good, @olperr1 let us know if you have ideas about automated testing of this maven plugin ...

It should be possible to test the plugin by using Maven Plugin Testing Harness. With this mechanism, one could retrieve the Mojo loaded with a test pom.xml configuration, and then call the execute() method on it.

I tried a little, but didn't succeed. Maybe the problem is related to the package-zip goal used by our plugin...

olperr1 avatar Nov 04 '24 08:11 olperr1