powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

Add network modification to action

Open pjeanmarie opened this issue 11 months ago • 1 comments

Please check if the PR fulfills these requirements

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • [ ] Yes
  • [ ] No

If yes, please check if the following requirements are fulfilled

  • [ ] The Breaking Change or Deprecated label has been added
  • [ ] The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

pjeanmarie avatar Mar 11 '24 13:03 pjeanmarie

Sonar raise coverage error mostly because of IDE generated equals and hashcode that I added for Rao (where they are tested) (where they are used by Set). Can we used some kind of automatic tests for these like https://mvnrepository.com/artifact/nl.jqno.equalsverifier/equalsverifier ?

pjeanmarie avatar May 07 '24 15:05 pjeanmarie

Sonar raise coverage error mostly because of IDE generated equals and hashcode that I added for Rao (where they are tested) (where they are used by Set). Can we used some kind of automatic tests for these like https://mvnrepository.com/artifact/nl.jqno.equalsverifier/equalsverifier ?

EqualsTester from guava-testlib is already used in powsybl-core to test the equals() methods. You can find several examples in the code. I think it would be better to use it instead. equalsverifier seems to be mostly maintained by one developer, which could be a problem.

olperr1 avatar May 13 '24 12:05 olperr1