powsybl-core
powsybl-core copied to clipboard
Add network modification to action
Please check if the PR fulfills these requirements
- [ ] The commit message follows our guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
- [ ] Yes
- [ ] No
If yes, please check if the following requirements are fulfilled
- [ ] The Breaking Change or Deprecated label has been added
- [ ] The migration steps are described in the following section
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
Sonar raise coverage error mostly because of IDE generated equals and hashcode that I added for Rao (where they are tested) (where they are used by Set). Can we used some kind of automatic tests for these like https://mvnrepository.com/artifact/nl.jqno.equalsverifier/equalsverifier ?
Sonar raise coverage error mostly because of IDE generated equals and hashcode that I added for Rao (where they are tested) (where they are used by Set). Can we used some kind of automatic tests for these like https://mvnrepository.com/artifact/nl.jqno.equalsverifier/equalsverifier ?
EqualsTester
from guava-testlib
is already used in powsybl-core to test the equals()
methods. You can find several examples in the code.
I think it would be better to use it instead. equalsverifier
seems to be mostly maintained by one developer, which could be a problem.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
90.5% Coverage on New Code
0.0% Duplication on New Code