powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

[WIP] Fix TCK unit tests

Open olperr1 opened this issue 1 year ago • 2 comments

Please check if the PR fulfills these requirements

  • [X] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

In the TCK, some tests process operations on already removed network elements. This may cause errors with custom IIDM implementations.

What is the new behavior (if this is a feature change)? No operations are processed on already removed network elements.

Does this PR introduce a breaking change or deprecate an API?

  • [ ] Yes
  • [X] No

If yes, please check if the following requirements are fulfilled

  • [ ] The Breaking Change or Deprecated label has been added
  • [ ] The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

olperr1 avatar Jan 09 '24 16:01 olperr1

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 10 '24 13:01 sonarqubecloud[bot]

We could add some code like : if (removed) { throw new PowsyblException("Cannot access xxxx of removed tie line " + id); } in the methods of TieLineImpl. Maybe in another PR

etiennehomer avatar Jan 10 '24 13:01 etiennehomer