powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

WIP Move dataframe from pypowsybl to core

Open nicolas-pierr opened this issue 1 year ago • 4 comments

Please check if the PR fulfills these requirements

  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? Move the dataframes that are implemented in pypowsybl

nicolas-pierr avatar Jun 30 '23 13:06 nicolas-pierr

I have some issues with the checkstyle plugin with some of the new syntax offered with the update to java 17. The commit bfe1cfd allows me to pass the checkstyle locally. But I am not sure it is what should be done on the whole powsybl project.

nicolas-pierr avatar Jul 25 '23 15:07 nicolas-pierr

I have some issues with the checkstyle plugin with some of the new syntax offered with the update to java 17. The commit bfe1cfd allows me to pass the checkstyle locally. But I am not sure it is what should be done on the whole powsybl project.

We are preparing a new powsybl-parent version which will use a newer version of maven-checkstyle-plugin. Once released, your hack will not be necessary.

olperr1 avatar Jul 25 '23 17:07 olperr1

The java17 syntax support was merged in main. If you update the branch, you will not need your "hack" anymore.

olperr1 avatar Aug 07 '23 12:08 olperr1

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 77 Code Smells

47.1% 47.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Aug 07 '23 15:08 sonarqubecloud[bot]