powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

Published 20 hours ago • verified publisher icon powsybl

[WIP] [Network Modification] Move method returning feeder by connectable in TopologyModificationUtils from pypowsybl

Open colinepiloquet opened this issue 2 years ago • 1 comments

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [x] The commit message follows our guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Moves code from pypowsybl to core, it makes more sense that it's there with all the other methods linked to topology modification. The rest of the code is also refactored. The PR in pypowsybl is not merged yet.

colinepiloquet avatar Sep 15 '22 13:09 colinepiloquet

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.1% 83.1% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 03 '22 11:10 sonarqubecloud[bot]

More tests of situations returning an empty list should be added.

miovd avatar Dec 05 '22 09:12 miovd

@colinepiloquet There are some failure tests, can you check?

miovd avatar Dec 08 '22 09:12 miovd

I fixed the test! It should be good now.

colinepiloquet avatar Dec 08 '22 10:12 colinepiloquet

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.2% 86.2% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 08 '22 13:12 sonarqubecloud[bot]