powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

Clean NetworkModification interface and implementations of complicated override methods

Open miovd opened this issue 2 years ago • 1 comments

Signed-off-by: VEDELAGO MIORA [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest Cleaning

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Making the code more understandable, readable and less error-prone: an abstract class is now created for network modifications and they all refer to one method being implemented (the one with most parameters)

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • [x] The Breaking Change or Deprecated label has been added
  • [ ] The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

miovd avatar Sep 02 '22 11:09 miovd