powsybl-core
powsybl-core copied to clipboard
Transform line on line into voltage level on line
Please check if the PR fulfills these requirements (please use '[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)
- [ ] The commit message follows our guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX'
and skip the rest
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
- [ ] The Breaking Change or Deprecated label has been added
- [ ] The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)
Other information: this PR must be merged after PR : https://github.com/powsybl/powsybl-core/pull/2228
(if any of the questions/checkboxes don't apply, please delete them entirely)
Just a general note about parameters naming: are they standard names? Not really a problem for me if not as long as they are well documented, but I am curious.
I also mostly agree with this PR, could you please rebase it on main so we can merge it even the other ones are still in discussion? Thank you.
Parameters naming are not standard names : I just use the names given in the US : https://dev.azure.com/GridSuite/MVP/_sprints/backlog/MVP%20Team/MVP/Sprint%2051?workitem=1233
This branch is based on branch https://github.com/powsybl/powsybl-core/pull/2228 , because it uses methods already added in TopologyModificationUtils and ModificationReports for that PR ...
Parameters naming are not standard names : I just use the names given in the US : https://dev.azure.com/GridSuite/MVP/_sprints/backlog/MVP%20Team/MVP/Sprint%2051?workitem=1233
Okay, no problem ! Can you just draw a scheme explaining where the different name are?
This branch is based on branch https://github.com/powsybl/powsybl-core/pull/2228 , because it uses methods already added in TopologyModificationUtils and ModificationReports for that PR ...
Could you add the used methods only? We are still in discussion with the other PRs and it might delay this one which is okay to be merged.
Parameters naming are not standard names : I just use the names given in the US : https://dev.azure.com/GridSuite/MVP/_sprints/backlog/MVP%20Team/MVP/Sprint%2051?workitem=1233
Okay, no problem ! Can you just draw a scheme explaining where the different name are?
This branch is based on branch #2228 , because it uses methods already added in TopologyModificationUtils and ModificationReports for that PR ...
Could you add the used methods only? We are still in discussion with the other PRs and it might delay this one which is okay to be merged.
The branch has been rebased on main A scheme explaining where the different name are is already present in ReplaceTeePointByVoltageLevelOnLine class