powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

Detach a voltage level from 2 lines (line split reverse action)

Open FranckLecuyer opened this issue 2 years ago • 2 comments

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • [ ] The Breaking Change or Deprecated label has been added
  • [ ] The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

FranckLecuyer avatar Aug 04 '22 08:08 FranckLecuyer

About the naming: I think the clearest name from a user's viewpoint would be something like RevertConnectVoltageLevelOnLine for a user to understand it is the reverse action even if it is not a really nice name.

miovd avatar Sep 02 '22 08:09 miovd

About the detached voltage level: I think you can directly delete it in any case (to be seen with @geofjamg and the GridSuite PO to check), it would be simpler to understand.

miovd avatar Sep 05 '22 13:09 miovd