powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

Create utility class for compareXml/compareTxt

Open miovd opened this issue 2 years ago • 1 comments

  • Do you want to request a feature or report a bug? Refactoring

  • What is the current behavior? Utility classes compareXml and compareTxt are in AbstractConverterTest

  • What is the expected behavior? These methods should be in a utility class ComparisonUtils

  • What is the motivation / use case for changing the behavior? Cleaner design

  • Please tell us about your environment:

    • PowSyBl Version: 4.10.0-SNAPSHOT

miovd avatar Jul 08 '22 09:07 miovd

Hi @miovd, I have worked to this issue in this PR: #2209 Please take a look, this is my first contribution and I hope that the changes are good Thank you

sfid98 avatar Jul 09 '22 12:07 sfid98