powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

Published 20 hours ago • verified publisher icon powsybl

CGMES export: refactor profile writers to use context

Open zamarrenolm opened this issue 2 years ago • 1 comments

Signed-off-by: Luma [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [X] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) code refactoring

What is the current behavior? (You can also link to an open issue here) The classes that write the profiles have static methods with too many parameters.

What is the new behavior (if this is a feature change)? Refactor writers of CGMES instance files to remove Sonar code smells and issues.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • [X] The Breaking Change or Deprecated label has been added
  • [ ] The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

zamarrenolm avatar May 31 '22 17:05 zamarrenolm

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

95.8% 95.8% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 27 '22 10:06 sonarqubecloud[bot]

A thorough review is required after the recent changes in export

zamarrenolm avatar Oct 31 '22 08:10 zamarrenolm

About this refactoring: not sure this is the best moment to work on it as the export will probably move a bit with the merging issues...

miovd avatar Dec 09 '22 15:12 miovd

About this refactoring: not sure this is the best moment to work on it as the export will probably move a bit with the merging issues...

I will try to keep the branch updated with main.

zamarrenolm avatar Dec 20 '22 15:12 zamarrenolm

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

96.0% 96.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 20 '22 15:12 sonarqubecloud[bot]

Can I close this old PR as no agreement has been found on that subject?

annetill avatar Jun 12 '23 12:06 annetill

Can I close this old PR as no agreement has been found on that subject?

Sure. We can reopen the task for cleaning-up export modules when the changes in this feature are less frequent.

zamarrenolm avatar Jun 12 '23 13:06 zamarrenolm

To be done in a future release.

zamarrenolm avatar Jun 12 '23 13:06 zamarrenolm