powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

Replacing Function with Predicate

Open Ruptam opened this issue 2 years ago • 1 comments

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest #798

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • [ ] The Breaking Change or Deprecated label has been added
  • [ ] The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Ruptam avatar Apr 11 '22 15:04 Ruptam

I think that print methods using Function<?, String> should not be changed to Predicates. The print methods expect a method that receive a Vertex or Edge and return its rendered description as a String.

zamarrenolm avatar Apr 12 '22 14:04 zamarrenolm