powsybl-core icon indicating copy to clipboard operation
powsybl-core copied to clipboard

[WIP] First try on CGMES Equipment network import

Open miovd opened this issue 3 years ago • 3 comments

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [x] The commit message follows our guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature

What is the current behavior? (You can also link to an open issue here) CGMES imported networks are always at STEADY_STATE_HYPOTHESIS validation level

What is the new behavior (if this is a feature change)? CGMES imported networks are at EQUIPMENT level if they only contains equipment-related profiles and boundaries (optional). The current PR only regards flows and generators' regulation. Other PRs are to follow.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • [x] The Breaking Change or Deprecated label has been added
  • [ ] The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

miovd avatar Feb 04 '22 14:02 miovd

I think we could also adjust the p0 and q0 functions in AbstractConductingEquipment to return NaN if no explicit value is given for p, q, instead of returning 0. Not only in the EnergyConsumerConversion.

zamarrenolm avatar Feb 11 '22 14:02 zamarrenolm

This PR is to be completed with other attributes but I'm letting it in its current state for us to agree on the design

miovd avatar Mar 15 '22 15:03 miovd