backbone-forms icon indicating copy to clipboard operation
backbone-forms copied to clipboard

Published 20 hours ago • verified publisher icon powmedia

Fixes #221: Allow select, radio, checkbox to be used outside a form

Open there4 opened this issue 11 years ago • 5 comments

  • Update select editor to setOptions handed to initialize. This provides similar functionality to both radio and checkbox. (They extend it)
  • Update unit tests for radio and checkbox to test that empty options can be intialized
  • Add unit test for new select behaviour.

This should update the library to once again support using a select editor outside of a form.

there4 avatar Apr 07 '13 18:04 there4

I'm still having this issue. Is there anything preventing this PR from being considered in the master?

there4 avatar Jan 27 '14 22:01 there4

Hi @there4, thanks for the PR. I've tried merging this but am getting a few failing tests; not sure if this is because of other code changes since this was applied but if you can pull from master and then make sure everything still works OK I can merge from there.

powmedia avatar Jan 29 '14 01:01 powmedia

Thanks for the update, I'll pull and update this PR tomorrow. Thanks for the help -

This really is a great project!

there4 avatar Jan 29 '14 01:01 there4

Hey @there4, I'd also like to see this merged. Can I help at all with getting the tests to pass?

reustle avatar Feb 15 '14 00:02 reustle

Hi @reustle - I had this functionality working in my fork. But I've been unable to devote any time to it this last week.

I /may/ be able to find some time early this week, but if you've got some time to spend on it, go for it! I was planning on looking back at my previous commit and essentially redoing that work on a fresh branch.

there4 avatar Feb 15 '14 17:02 there4