backbone-forms icon indicating copy to clipboard operation
backbone-forms copied to clipboard

Use predefined, abstracted ModalAdapter...

Open mitchellrj opened this issue 12 years ago • 4 comments

... rather than duplicate, hardcoded Backbone.BootstrapModal & allow customization in the schema.

Not added more tests as test file doesn't test modal stuff yet.

mitchellrj avatar Mar 07 '13 11:03 mitchellrj

Might be worth waiting until #196 is resolved until this is merged.

mitchellrj avatar Mar 11 '13 23:03 mitchellrj

The bootstrapmodal isn't hardcoded any more, you can replace it by doing:

Backbone.Form.List.Modal.ModalAdapter = MyModalAdapter

powmedia avatar Mar 12 '13 10:03 powmedia

If you look at line 502, you can see that it actually still is. This pull also allows a different modal adapter to be specified per field.

mitchellrj avatar Mar 12 '13 10:03 mitchellrj

I replaced that instance previously - it's on the latest version in master

powmedia avatar Mar 12 '13 11:03 powmedia