powertabeditor icon indicating copy to clipboard operation
powertabeditor copied to clipboard

Repeat Endings don't work in playback

Open Majicmanmaj1 opened this issue 11 years ago • 6 comments

When playing back a tab the repeat endings are not followed and the piece is played straight through as if there are no repeat markings.

Majicmanmaj1 avatar Jul 29 '14 18:07 Majicmanmaj1

It works for me on the tabs that I've tried - can you provide a link to an example file where repeats don't play back?

cameronwhite avatar Jul 30 '14 22:07 cameronwhite

So I created a couple test files. They're not identical. But the one created in 1.7 works. The one created in 2.0 does not. I'll check into it more tomorrow.

https://onedrive.live.com/redir?resid=BF1A7BA5AAA1B4E4!166&authkey=!AARzi9Ot8fmFVH0&ithint=folder%2c

Canaanabolaanan avatar Jul 31 '14 03:07 Canaanabolaanan

The tab I was looking at was this one - http://members.powertabs.net/tablature.php?id=29368 The section that is affected is bar 13 to 16.

Majicmanmaj1 avatar Jul 31 '14 16:07 Majicmanmaj1

@Canaanabolaanan - your file should be fixed now. The repeat bar only had two repeats, and the MIDI player previously was ignoring repeats where the number of alternate endings didn't exactly match the repeat count.

@Majicmanmaj1 - I suspect this change will fix your issue as well (I can't access your file since my old login doesn't seem to work anymore ...), but please re-open this issue if you still see this issue in the next alpha release.

cameronwhite avatar Aug 13 '14 02:08 cameronwhite

It's still playing ending repeats incorrectly. The test file also plays incorrectly. It should play: m1 m2 m1 m2 m1 m3. Instead it plays: m1 m2 m1 m2 m3.

The first two systems demonstrate this and should be solvable. The rest of the tab is incorrectly written as a test.

Canaanabolaanan avatar Aug 20 '14 01:08 Canaanabolaanan

I have some tabs from PT 1.7 which display erroneous repeat behaviour in latest master, in a similar manner as described above. Investigating at the moment (mainly learning the code first :) )

moppius avatar Dec 18 '16 18:12 moppius