powertabeditor icon indicating copy to clipboard operation
powertabeditor copied to clipboard

Adjust horizontal centering spacing for rest

Open sbonaime opened this issue 1 month ago • 3 comments

Description of Change(s)

Adjust horizontal centering spacing for rest

Fixes Issue(s)

Fix #540

sbonaime avatar Nov 19 '25 10:11 sbonaime

Thanks for looking at this!

While doing some testing I noticed that the new spacing didn't look as good for some durations like half rests, so perhaps the alignment needs some different settings per type

Screenshot 2025-11-22 at 10 18 24 PM

cameronwhite avatar Nov 23 '25 03:11 cameronwhite

Maybe we should takie into account the width and height of each symbol before placing them. Or maybe at the drawing stage ? Few examples were symbol width is important :

Tremolo picking Capture d’écran 2025-11-24 à 10 59 30

Vibrato Capture d’écran 2025-11-24 à 10 59 42

Large Vibrato and vibrato Capture d’écran 2025-11-24 à 11 01 01

sbonaime avatar Nov 24 '25 09:11 sbonaime

Yeah, there should ideally be some adjustments depending on the symbol

I recall it being hard to get accurate information about the width of each symbol from the Qt font info classes, which is why there are a lot of hardcoded scale factors in the layout code.

cameronwhite avatar Nov 24 '25 23:11 cameronwhite