powertabeditor icon indicating copy to clipboard operation
powertabeditor copied to clipboard

Improve colors in the "Dark" score theme

Open BigHonkinDaddy opened this issue 3 years ago • 7 comments

Description The Dark score theme (accessed under File->Preferences->General is my preference and is useful especially for creating split screen videos that combine video of my performances with the video screen capture of the tabs from Powertab's Midi player. The "dark" them works best, visually, for this. However, the midi player controls (blue and red) are hard to see and follow in the dark theme. Furthermore, tied notes which are light grey are not easily distinguishable from the white notes/tabs in the dark theme.

Would love to see the color scheme under the "dark" theme improved - maybe even allow for users to assign their own colors to the midi player and score elements.

Lastly, the "Dark" theme seems only to apply to the score itself, leaving the menu bar, toolbar, mixer, and instrument windows still in the default light grey. Would like to see the "dark" theme apply to the entire application.

BigHonkinDaddy avatar Jan 09 '22 20:01 BigHonkinDaddy

Yep, the score colours could definitely use a bit of tweaking!

The rest of the widgets are following the system theme, so if you have a dark theme set that should be respected (e.g. https://powertab.github.io/images/screenshot_macos.png) . It would be possible to add some customization on our end, though

cameronwhite avatar Jan 09 '22 21:01 cameronwhite

Huh. I have my Windows 10 in "dark mode" but only see the original "light" version of PT. Not a huge deal, but wonder what I'm doing wrong... Bug Example screen shot

BigHonkinDaddy avatar Jan 10 '22 12:01 BigHonkinDaddy

Thanks, yeah looking around on Google it sounds like Qt doesn't handle the Windows dark theme yet, so we'll probably have to do something ourselves

cameronwhite avatar Jan 10 '22 14:01 cameronwhite

I've made some changes to tied notes and the caret to hopefully be better in the dark theme: Before: before After: after

cameronwhite avatar Jan 28 '22 03:01 cameronwhite

Looks great!

BigHonkinDaddy avatar Jan 28 '22 12:01 BigHonkinDaddy

Can this issue be closed ?

luzpaz avatar Dec 15 '23 09:12 luzpaz

I think the remaining work here was to have a dark theme for the whole application, like for the Windows screenshot above

cameronwhite avatar Dec 15 '23 18:12 cameronwhite