Alex Efros

Results 251 comments of Alex Efros

Ну, заодно практика в английском, двойная польза. :-) Так что, repro сделаете? Пока у меня проблема не воспроизведётся - чинить нечего. Это же несложно, можно для начала просто добавить в...

@igorog Я для Neovim сделал новый плагин: https://github.com/powerman/ruscmd.nvim. Но в процессе работы над ним нашёл ещё более продвинутый вариант, который автоматически создаёт русские маппинги для всех существующих: https://github.com/Wansmer/langmapper.nvim (как раз...

> It should either create an explicit copy It does that - by using non-pointer receiver. > or be a standalone function Function will do the same (receive arg of...

TBH I don't see much use for this pattern except for Config-like structures. But Config structures are wide spread, so IMO it's worth support. For Config structures it's important to...

> the receiver copy is not returned but used, after modification, to build a struct of a different type While this is not an error by itself, I doubt this...

> The branch with the modified version is [here](https://github.com/mgechev/revive/tree/fix/1066), feedback is welcome. Works for me.

@denisvmedia @ccoVeille It looks like you both missed the "The idea is to remove these failures in the final version of the rule." part of @chavacava message. I read it...

> Something like, returning a struct from struct, but updating a counter in the struct. Can you show an example of such a code, please? To avoid some more misunderstanding....

> as I said it's hypothetical, but something like this maybe Hypothetical is okay, but why do you think this code is wrong? To me this example looks exactly like...

> Then we have to discuss if it's a problem or not. Can you please explain why do you think we have to discuss this code? At a glance I...