sourcemod-nativevotes icon indicating copy to clipboard operation
sourcemod-nativevotes copied to clipboard

Prevent NativeVote menu callback from freeing in-use forward handle

Open nosoop opened this issue 5 years ago • 1 comments

Quick-fix while alliedmodders/sourcemod#1041 gets sorted out.

SourceMod doesn't seem to take kindly to a forward handle being deleted while it's being invoked, which is what Handler_NV_MapVoteMenu does with NativeVote.Clear() in nativevotes_mapchooser.sp. This seemingly didn't have disastrous consequences until Debian 10.

All this does is ensure that the handle remains valid for the duration of the private forward call.

nosoop avatar Jul 10 '19 10:07 nosoop

@powerlord pls

Naleksuh avatar Apr 26 '21 22:04 Naleksuh