learning_gem5 icon indicating copy to clipboard operation
learning_gem5 copied to clipboard

Added Regression system to Extending gem5 part

Open fusiled opened this issue 6 years ago • 3 comments

This commit adds a section in which is explained how to extend the regression system.

fusiled avatar May 29 '18 15:05 fusiled

Hi Matteo,

Thanks for the contribution! It's definitely important to document how to use the testing and regression system!!

I'm going to hold off on accepting this PR right now because I'm hoping to replace the regression system with a more user-friendly interface. You can see the set of patches here: https://gem5-review.googlesource.com/q/topic:%22test-framework-WIP%22+(status:open%20OR%20status:merged) starting with https://gem5-review.googlesource.com/c/public/gem5/+/4880/6.

If you have time to review those patches, it would be very helpful.

After those get in, we can iterate on this to make it work for the new testing system.

powerjg avatar May 29 '18 17:05 powerjg

Hi Jason,

That's completely fine. Actual regression testing is really cumbersone and it's not very clear how to use by looking at the gem5 wiki. Since this book is the best resource online, i think it was worth contribute to it. As soon a i can i'll take a look to the patches.

On Tue, May 29, 2018, 19:11 Jason Lowe-Power [email protected] wrote:

Hi Matteo,

Thanks for the contribution! It's definitely important to document how to use the testing and regression system!!

I'm going to hold off on accepting this PR right now because I'm hoping to replace the regression system with a more user-friendly interface. You can see the set of patches here: https://gem5-review.googlesource.com/q/topic:%22test-framework-WIP%22+(status:open%20OR%20status:merged) starting with https://gem5-review.googlesource.com/c/public/gem5/+/4880/6.

If you have time to review those patches, it would be very helpful.

After those get in, we can iterate on this to make it work for the new testing system.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/powerjg/learning_gem5/pull/27#issuecomment-392859160, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdbXkg3aY7X6jDtFrGJMZIY8ILEJHV5ks5t3YE6gaJpZM4URu5q .

fusiled avatar May 29 '18 17:05 fusiled

Cumbersome is an understatement :). Thanks for taking a stab at the documentation!

On Tue, May 29, 2018 at 10:25 AM Matteo Maria Fusi [email protected] wrote:

Hi Jason,

That's completely fine. Actual regression testing is really cumbersone and it's not very clear how to use by looking at the gem5 wiki. Since this book is the best resource online, i think it was worth contribute to it. As soon a i can i'll take a look to the patches.

On Tue, May 29, 2018, 19:11 Jason Lowe-Power [email protected] wrote:

Hi Matteo,

Thanks for the contribution! It's definitely important to document how to use the testing and regression system!!

I'm going to hold off on accepting this PR right now because I'm hoping to replace the regression system with a more user-friendly interface. You can see the set of patches here:

https://gem5-review.googlesource.com/q/topic:%22test-framework-WIP%22+(status:open%20OR%20status:merged)

starting with https://gem5-review.googlesource.com/c/public/gem5/+/4880/6.

If you have time to review those patches, it would be very helpful.

After those get in, we can iterate on this to make it work for the new testing system.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/powerjg/learning_gem5/pull/27#issuecomment-392859160 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ACdbXkg3aY7X6jDtFrGJMZIY8ILEJHV5ks5t3YE6gaJpZM4URu5q

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/powerjg/learning_gem5/pull/27#issuecomment-392864774, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGsHHh3v0gBZz3iXAjsvKWLEZs9cP5dks5t3YRngaJpZM4URu5q .

powerjg avatar May 29 '18 17:05 powerjg