Jason Lowe-Power
Jason Lowe-Power
@giactra let me know if you want us to hold off merging until you have time to review.
Can you give some context to this change? What is the problem it is fixing? Why did you take this approach? Etc.
> I was probably being too optimistic/demanding to say we want this in that quickly. As long as this is being actively worked on to a reasonable extent, I'm happy....
We are planning to merge this once we get most of the PRs listed in #558 merged. So, anyone that has an open PR right now that is not in...
Thanks @trollet91 for pushing on this! @BobbyRBruce is taking it over (apologies for not making that clear in this thread). @andysan, we'll have 2 weeks of testing the staging branch...
@andysan Some of these points are important and need to be taken into account. However, we've agreed in the past that the goal is to get *close* to the current...
> Honestly, it's not that much effort I just went over a few files and I have managed to reduce it quite substantially for those files. If you've already gone...
I don't disagree with anything you're saying @andysan. However, what I'm seeing is that we have been working on merging clang-format for *over 2 years*. See https://gem5-review.googlesource.com/c/public/gem5/+/49063 for the beginning...
Would you be willing to talk about this in the next gem5-dev meeting? This is super cool!
> I think this is something that is worth considering. IIRC, black enforces 88 characters for Python (unless we changed that). I would be reluctant to go much longer since...