powellnorma

Changes are from ndgsa, see: https://github.com/user234683/youtube-local/issues/241#issuecomment-3217863500

Auto-dubbed audio track is chosen over original audio track

6

This check right here is not enough: https://github.com/user234683/youtube-local/blob/f9306ca0c7c3c154dab16ec9ea1a2a3393a31e93/youtube/yt_data_extract/watch_extraction.py#L475 Because the entire player_response does not seem to include the original audio track. Example video: https://www.youtube.com/watch?v=TDy14akJOw0

DonchianChannels and input_sampling

2

I think currently the input_sampling works by just removing the last output value and recalculating it with the current input. However, for DonchianChannels, I think it should keep the lowest...

``` # 5min candles c1 = OHLCV(time=datetime.fromisoformat('2024-01-02T15:45:00+00:00'), open=1, high=2, low=3, close=4) c2 = OHLCV(time=datetime.fromisoformat('2024-01-02T15:50:00+00:00'), open=1, high=2, low=3, close=4) s = Sampler(SamplingPeriodType.MIN_15) print(s.is_same_period(c1, c2)) ``` I think usually the time of...