PovioKit icon indicating copy to clipboard operation
PovioKit copied to clipboard

UI/Dialog

Open markom-povio opened this issue 3 years ago • 2 comments

Component requirements:

A UI component that effectively replaces and extends native UIActionSheet.

  • [x] dynamically expandable based on the content height
  • [x] pan gesture to dismiss
  • [x] tap gesture behind it to dismiss
  • [x] custom transition animations / can be expandable
  • [x] custom presentations; it can be presented at the bottom like a regular action sheet or centered as a modal

TODO:

  • [x] Demo project is created on separate branch: Dialog demo
  • [x] Documentation

Demo video (updated 14.10.2022.):

https://user-images.githubusercontent.com/95407653/195816096-0b1271aa-7e2c-4734-b107-ae24a08388ca.MP4

markom-povio avatar Apr 27 '22 12:04 markom-povio

I've just tested this out and here is the report:

  • i don't see a "swipe down" gesture to dismiss dialogue, and it should support interactive dismiss
  • i would like to fixate the height of the dialogue, sometimes it half the screen height or any arbitrary height; the content should scroll inside dialogue
  • when presenting the dialogue, there is some semitransparent background on the viewcontroller
  • in the demo app, when use "simple animation" with "bottom" type, scrolling to the top will reveal the rootController at the bottom of the screen

borut-t avatar Jan 18 '23 12:01 borut-t

Added:

  • "swipe down to dismiss" interactive gesture.
  • option to set a custom height
  • fix for scrolling to the top will reveal the rootController at the bottom of the screen

Info regarding this issue:

when presenting the dialogue, there is some semitransparent background on the viewController

This is set in the demo project with: setDialogBackground() but I have removed it to avoid confusion.

markom-povio avatar Feb 03 '23 15:02 markom-povio

I appreciate your work on this @markom-povio, but we have moved our focus towards SwiftUI components. Since this can be easily done with .sheet modifier, I'll close this PR.

borut-t avatar Aug 02 '24 11:08 borut-t