phpmnd icon indicating copy to clipboard operation
phpmnd copied to clipboard
verified publisher icon povils

fixes #98

Open SignpostMarv opened this issue 5 years ago • 8 comments

  • d31251f applies the actual fix for #98
  • 18df263 is to make sure that d31251f didn't break anything
  • e42db9b is to fix a build failure caused by deprecated ReflectionType::__toString() usage.
  • b724f9a & 309a88e are to allow install alongside phpunit 9

SignpostMarv avatar Feb 13 '20 11:02 SignpostMarv

scrutinizer / appveyor failures do not appear related to changes made.

SignpostMarv avatar Feb 13 '20 12:02 SignpostMarv

Do not understand why #101 #102 and #104 are not yet merged

juliangut avatar Apr 03 '20 09:04 juliangut

@SignpostMarv The build is failing any chance you can look ?

exussum12 avatar Sep 24 '21 17:09 exussum12

@exussum12 currently awaiting return of computer so I can work on dev things again.

SignpostMarv avatar Sep 25 '21 08:09 SignpostMarv

@exussum12 computer returned today, will need to schedule time this week to look at a rebase/merge

SignpostMarv avatar Oct 04 '21 19:10 SignpostMarv

looks good to me. Thanks.

@sidz happy with this one ?

exussum12 avatar Oct 06 '21 08:10 exussum12

it's probably worth mentioning that as this PR is a little over a year old, I've lost the original context for when the issue occurs 🤷‍♂️

SignpostMarv avatar Oct 06 '21 08:10 SignpostMarv

@SignpostMarv I assume that there were some incompatibility issues with newest symfony/console.

Currently we need to bump up minimum version of symfony/console to 4.4 as current 4.0 has some incompatibilities with PHP 7.4.

we will do it in separate branch

sidz avatar Oct 06 '21 08:10 sidz